Fixed PARTION BY Clause in Sat v0 for Fabric #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkiehn
added
the
testing
This comment was marked as outdated.
This comment was marked as outdated.
remoteworkflow
bot
removed
the
testing
tkirschke
added
the
testing
This comment was marked as duplicate.
This comment was marked as duplicate.
remoteworkflow
bot
removed
the
testing
tkiehn
added
the
testing
This comment was marked as duplicate.
This comment was marked as duplicate.
remoteworkflow
bot
removed
the
testing
|
Link to workflow summary: https://github.com/ScalefreeCOM/datavault4dbt-ci-cd/actions/runs/11915425109 RESULTS for Synapse: RESULTS for Postgres: RESULTS for BigQuery: RESULTS for Redshift: RESULTS for Snowflake: RESULTS for Exasol: RESULTS for Fabric: RESULTS for Oracle: RESULTS for Databricks: |
tkiehn
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sat v0 Macro for Fabric had a "|lower" after the hashky inside the "PARTITION BY" clauses. This causes issues with column names, if they are upper case.
Type of change
Please delete options that are not relevant.