Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Add support for parsing mxc urls as images in reactions #208

Closed
Sid127 opened this issue Aug 28, 2023 · 2 comments
Closed

[FEATURE REQUEST] Add support for parsing mxc urls as images in reactions #208

Sid127 opened this issue Aug 28, 2023 · 2 comments
Labels
enhancement New feature or request parity-with-android SchildiChat-Android has this already

Comments

@Sid127
Copy link

Sid127 commented Aug 28, 2023

This exists in SchildiChat android, but not on Desktop or Web. It'd be helpful to users who use Matrix with bridges as custom reactions on some platforms show up as mxc urls on SchildChat, with there being no way for a user to figure out what the reaction actually is without logging into the source platform
@SpiritCroc
Copy link
Member

Already planned and implemented in the image-reaction-* branches in our matrix-sdk, hopefully the next few upstream merges don't break it so we can merge it for a future release

@SpiritCroc SpiritCroc added enhancement New feature or request parity-with-android SchildiChat-Android has this already labels Sep 5, 2023
@SpiritCroc
Copy link
Member

Nevermind, upstream merged it, so we will get it once we merge the upstream version that has it: matrix-org/matrix-react-sdk#11087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request parity-with-android SchildiChat-Android has this already
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpiritCroc @Sid127