Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken constructor in v1.5 #65

Closed
mhauru opened this issue Jun 25, 2024 · 1 comment · Fixed by #67
Closed

Broken constructor in v1.5 #65

mhauru opened this issue Jun 25, 2024 · 1 comment · Fixed by #67

Comments

@mhauru
Copy link

mhauru commented Jun 25, 2024

ADTypes.AutoReverseDiff(false) used to be a valid way to call the constructor before v1.5 and efdc12e, but now only the keyword argument version works. I appreciate that the positional argument constructor was undocumented, but maybe a deprecation warning could still be put in place?

@ChrisRackauckas
Copy link
Member

Yeah we can add that as a deprecation path. Totally not intended as a constructor to use before 😅, but no harm in making it a deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants