feat: add ConstructionBaseExt to allow Setfield and Functors support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Nov 13, 2024
avik-pal
force-pushed
the
ap/constructionbase
branch
from
4cff972
to
b05286d
Compare
|
Please don't merge before I have a chance to review |
4 tasks
|
Please review now then? It's very uncontroversial. |
gdalle
requested changes
Nov 13, 2024
It is currently 23:18 where I live. I don't think this change is so urgent that it cannot wait 24h. |
This was referenced Nov 13, 2024
Closed
gdalle
requested changes
Nov 14, 2024
gdalle
reviewed
Nov 14, 2024
Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com>
|
You can go ahead and merge, I trust Chris' review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
All documentation related to code changes were updatedcontributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Any new documentation only uses public APIAdditional context
Functors v0.5 started defaulting to recurse into all types, which means we need to be able to reconstruct types based on ConstructionBase. See https://github.com/LuxDL/Lux.jl/actions/runs/11825400363/job/32949087528?pr=1069#step:6:50