Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpl2 #23

Closed
marqh opened this issue Mar 3, 2017 · 2 comments
Closed

mpl2 #23

marqh opened this issue Mar 3, 2017 · 2 comments

Comments

@marqh
Copy link
Member

marqh commented Mar 3, 2017

there is a potential bug with respect to matplotlib2 in tick locations

the version of mpl is now pinned, pending this fix

https://github.com/SciTools/nc-time-axis/blob/master/nc_time_axis/tests/unit/test_NetCDFTimeDateLocator.py#L99
https://github.com/SciTools/nc-time-axis/blob/master/nc_time_axis/tests/unit/test_NetCDFTimeDateLocator.py#L107
https://github.com/SciTools/nc-time-axis/blob/master/nc_time_axis/tests/unit/test_NetCDFTimeDateLocator.py#L111

ref #22
@QuLogic
Copy link
Member

QuLogic commented Mar 7, 2017

There are two problems. Firstly, MaxNLocator changed with mpl2; tests could maybe be fixed by setting classic style first. Secondly, this code supplies invalid steps; it should start at 1 and end at 10 (as specified in the MaxNLocator docs).

@marqh
Copy link
Member Author

marqh commented Mar 7, 2017

thanks for the tips @QuLogic

@ocefpaf ocefpaf mentioned this issue May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuLogic @marqh