Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Better description for updating scoop error #5589

Closed
doraeric opened this issue Jul 25, 2023 · 3 comments · Fixed by #5424
Closed

[Feature] Better description for updating scoop error #5589

doraeric opened this issue Jul 25, 2023 · 3 comments · Fixed by #5424

Comments

@doraeric
Copy link

Feature Request

Is your feature request related to a problem? Please describe.

It's not a real problem. Just an advice for better description for error handling.

Describe the solution you'd like

Currently, the code shows

Scoop update failed. Folder in use. Paste $newdir into $currentdir.

Since .git is a hidden folder, the user may copy contents except .git from old folder to new folder, resulting .git is still missing.
I think tell the user to rename folder would be a better choice.

Describe alternatives you've considered

Ask to user to rename folders may be a better choice, such as

Scoop update failed. Folder in use. Please rename folders $currentdir to `old` and $newdir to `current` manually.
@HUMORCE
Copy link
Member

HUMORCE commented Jul 28, 2023

Basically, we just need to execute scoop update again when Scoop Core Dir are not occupied.

@doraeric
Copy link
Author

doraeric commented Jul 28, 2023

The problem is that the directory is occupied by scoop when running scoop update, so it needs to be fixed by the user.
And if a user didn't copy the hidden .git folder from $newdir to old directory, he needs to copy everything from new directory every time.

@HUMORCE
Copy link
Member

HUMORCE commented Jul 29, 2023

Scoop Core Dir will not be occupied when executing scoop update, unless you have opened it or it's sub-files in another program. e.g. A terminal cd to the dir

Your change request for this instruction is correct, because the .git dir may not included when copying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants