Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Environment variables in env_set are not correctly replaced after version 0.5.0 #6043

Closed
Vixb1122 opened this issue Jul 6, 2024 · 8 comments · Fixed by #6057
Closed
Labels

Comments

@Vixb1122
Copy link

Vixb1122 commented Jul 6, 2024

Bug Report

Assume the scoop path is D:\Scoop, the application name is trilium, and the configuration is as follows:

"env_set": {
    "TRILIUM_DATA_DIR": "$persist_dir\\trilium-data"
}

Current Behavior

In the environment variables, the value of TRILIUM_DATA_DIR is $persist_dir\trilium-data.

Expected Behavior

In the environment variables, the value of TRILIUM_DATA_DIR should be D:\Scoop\persist\trilium\trilium-data.

Additional context/output

Possible Solution

Revert to the behavior of the previous version.

System details

Windows version: 11

OS architecture: 64bit

PowerShell version:

Major  Minor  Patch  PreReleaseLabel BuildLabel
-----  -----  -----  --------------- ----------
7      4      3

Additional software:

Scoop Configuration

{
  "last_update": "2024-07-06T13:01:04.5869117+08:00",
  "scoop_repo": "https://github.com/ScoopInstaller/Scoop",
  "scoop_branch": "master",
  "use_sqlite_cache": true
}
@Vixb1122 Vixb1122 added the bug label Jul 6, 2024
@qwertyhjklxyz
Copy link
Contributor

@niheaven Restore the previous version's behavior by adding $persist_dir, or change the app manifest to adapt to the changes?

@niheaven
Copy link
Member

niheaven commented Jul 8, 2024

Okay, it's a bug from #5968, I'll fix it soon.

@Vixb1122
Copy link
Author

Vixb1122 commented Jul 9, 2024

Hope to release a new version based on this fix as soon as possible. @niheaven

@Jordan-Haidee
Copy link

Jordan-Haidee commented Jul 9, 2024

It seems that this fix didn't take effect at all now, which caused all python virtual envs on my computer was destoryed after scoop updated.😭 @niheaven
image

@niheaven
Copy link
Member

niheaven commented Jul 9, 2024

The fix has been applied to the develop branch; please reset any applications that were impacted.

@fritzmg
Copy link

fritzmg commented Jul 10, 2024

Is there a way to downgrade scoop temporarily to be able to fix this issue?

@Vixb1122
Copy link
Author

Is there a way to downgrade scoop temporarily to be able to fix this issue?

scoop config scoop_branch develop

@W1M0R
Copy link

W1M0R commented Jul 16, 2024

This effects the rustup package as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants