0.10.6: still issues with conflicting implementations of trait

[frederikhors]

Since #1287 is closed I just tried 0.10.6: unfortunately the issue is still there:

impl Related<super::tenant::Entity> for Entity {
    fn to() -> RelationDef {
        super::house::Relation::Tenant.def()
    }
    fn via() -> Option<RelationDef> {
        Some(super::house::Relation::Player.def().rev())
    }
}

impl Related<super::tenant::Entity> for Entity {
    fn to() -> RelationDef {
        super::offer::Relation::Tenant.def()
    }
    fn via() -> Option<RelationDef> {
        Some(super::offer::Relation::Player.def().rev())
    }
}

with error:

error[E0119]: conflicting implementations of trait `sea_orm::Related<generated::tenant::Entity>` for type `generated::player::Entity`
  --> src\entities\player.rs:65:1
   |
56 | impl Related<super::tenant::Entity> for Entity {
   | ---------------------------------------------- first implementation here
...
65 | impl Related<super::tenant::Entity> for Entity {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `generated::player::Entity`

error[E0119]: conflicting implementations of trait `sea_orm::Related<generated::player::Entity>` for type `generated::tenant::Entity`
   --> src\entities\tenant.rs:135:1
    |
117 | impl Related<super::player::Entity> for Entity {
    | ------------------------------------------------ first implementation here
...
135 | impl Related<super::player::Entity> for Entity {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `generated::tenant::Entity`

The entities in this case are:

Player {
    pub tenant_id: String,
}

House {
    pub tenant_id: String,
    pub player_id: String,
}

Offer {
    pub tenant_id: String,
    pub player_id: String,
}

I'll downgrade to 0.10.2 for now.

On other entites there is the same issue too (because of tenant_id).

[billy1624]

Hey @frederikhors, sorry for the delay. I was not able to reproduce the error. Could you please provide a sample SQL like below?

create table if not exists player
(
    id integer
);

create unique index if not exists player_id_uindex
    on player (id);

create table if not exists tenant
(
    id integer
);

create unique index if not exists tenant_id_uindex
    on tenant (id);

create table if not exists house
(
    tenant_id integer
        constraint house_tenant_id_fk
            references tenant (id),
    player_id integer
        constraint house_player_id_fk
            references player (id)
);

create table if not exists offer
(
    tenant_id integer
        constraint offer_tenant_id_fk
            references tenant (id),
    player_id integer
        constraint offer_player_id_fk
            references player (id)
);

[frederikhors]

I'll in a few hours. Sorry for the delay.

[billy1624]

Thanks!! @frederikhors No rush!

[ryanoillataguerre]

+1 to this, blocking my migration to sea-orm at the moment :/

These are with freshly generated entity files from sea-orm-cli and two many-to-many tables, users_saved_bills, and users_votes

[frederikhors]

@ryanoillataguerre, can you post your sql? I cannot right now since I switched project.

[ryanoillataguerre]

Hey @frederikhors no problem, here it is below:

CREATE TABLE users
(
  id uuid  PRIMARY KEY  DEFAULT uuid_generate_v1mc(),
  email TEXT UNIQUE NOT NULL,
  ...
);

CREATE TABLE bills
(
  id uuid  PRIMARY KEY  DEFAULT uuid_generate_v1mc(),
  ...
);

CREATE TABLE users_votes
(
  user_id uuid REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE,
  bill_id uuid REFERENCES bills (id) ON UPDATE CASCADE ON DELETE CASCADE,
  vote boolean NOT NULL,
  CONSTRAINT users_bills_pkey PRIMARY KEY (user_id, bill_id)
);

CREATE TABLE users_saved_bills
(
  user_id uuid REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE,
  bill_id uuid REFERENCES bills (id) ON UPDATE CASCADE ON DELETE CASCADE,
  CONSTRAINT users_saved_bills_pkey PRIMARY KEY (user_id, bill_id)
);

[ryanoillataguerre]

Is there another way to define these many to manies that I'm not catching in my SQL?

[billy1624]

Thanks everyone for the help!! Please check this PR

• Generate entity for duplicated many-to-many paths #1435

[ryanoillataguerre]

Thanks everyone for the help!! Please check this PR

• Generate entity for duplicated many-to-many paths #1435

This is awesome, thanks @billy1624 ! Hope it gets merged soon.

Out of curiosity, does this problem only show up for non-sea-orm migration-defined tables? Like if I were to rewrite my migrations in Rust how the Getting Started guide does it, would this conflict not happen?