Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate arbitrary named entity #70

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Generate arbitrary named entity #70

merged 4 commits into from
Aug 10, 2021

Conversation

billy1624
Copy link
Member

Resolve #69

@billy1624 billy1624 self-assigned this Aug 10, 2021
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 10, 2021

When the check all passes, we should release a new codegen
And remove the path = in cli.toml

@billy1624
Copy link
Member Author

billy1624 commented Aug 10, 2021 •
edited
Loading

I guess it's okay to keep the line?

https://github.com/launchbadge/sqlx/blob/55c603e9e709ae62f3ef80ab7656efc5b41a6ffb/sqlx-macros/Cargo.toml#L88-L89
https://docs.rs/crate/sqlx-macros/0.5.5/source/Cargo.toml

@billy1624 billy1624 force-pushed the gen-arbitrary-named-entity branch from 789c337 to 898020d Compare August 10, 2021 04:14
@billy1624 billy1624 force-pushed the gen-arbitrary-named-entity branch from f9cb78f to 8823157 Compare August 10, 2021 04:34
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 10, 2021

I think the problem of path = is it will trick the CI server to not use the production build.

@billy1624
Copy link
Member Author

I think the problem of path = is it will trick the CI server to not use the production build.

Ok, so I publish sea-orm-codegen & cli-orm-cli first, then remove the path = "..." from this PR?

@tyt2y3 tyt2y3 merged commit ba226a2 into master Aug 10, 2021
@tyt2y3 tyt2y3 deleted the gen-arbitrary-named-entity branch August 10, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error for sqlx_migrations table when generating entities
2 participants
@billy1624 @tyt2y3