Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add #[serde(skip_serializing)] and #[serde(skip_deserializing)] to hidden collumns #961

Closed
HigherOrderLogic opened this issue Aug 11, 2022 · 2 comments · Fixed by #1171 or #1320
Labels
good first issue Good for newcomers
Milestone

Comments

@HigherOrderLogic
Copy link
Contributor

Motivation

Since we don't generate entity for hidden table (which has name starts with underscore) by default so it'd be good to add #[serde(skip_serializing)] and #[serde(skip_deserializing)] to hidden columns, too.

Proposed Solutions

N/A

Additional Information

N/A

@billy1624
Copy link
Member

Hey @HigherOrderLogic, thanks for proposing this on Discord!

I'll open this for contributions! I second this as long as it's opt-in, i.e. feature is disabled by default and can be choose to enabled by will.

@billy1624 billy1624 added the good first issue Good for newcomers label Aug 15, 2022
@billy1624 billy1624 moved this to Triage in SeaQL Dev Tracker Aug 15, 2022
@billy1624 billy1624 moved this from Triage to Open for Contributions in SeaQL Dev Tracker Aug 15, 2022
@Sculas
Copy link
Contributor

Sculas commented Aug 19, 2022

You don't need to add both, adding #[serde(skip)] does the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
3 participants