From debb421dadf04b7c7300cde234ed8ac9e863e2e1 Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Sun, 31 Jul 2022 23:00:19 -0600 Subject: [PATCH 1/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- .xperior/testds/motr-single_tests.yaml | 8 +++++++- utils/functions | 7 +++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.xperior/testds/motr-single_tests.yaml b/.xperior/testds/motr-single_tests.yaml index e280ff99e35..9cc8eef7cfc 100644 --- a/.xperior/testds/motr-single_tests.yaml +++ b/.xperior/testds/motr-single_tests.yaml @@ -490,7 +490,13 @@ Tests: - id : 37protocol script : 'm0 run-st 37protocol' dir : src/scripts - executor : Xperior::Executor::MotrTest + # this ST checks checksum of the BE structures during + # developmental phase they are bound to fail so code + # changes are required but ST has to be in disabled + # state for now when the release is in GA phase we will + # enable the ST again to ensure there will be no changes + # in BE structures. + executor : Xperior::Executor::Skip sandbox : /var/motr/root/sandbox.st-37protocol groupname: 01motr-single-node polltime : 30 diff --git a/utils/functions b/utils/functions index c66a933a012..059220f9b77 100755 --- a/utils/functions +++ b/utils/functions @@ -33,6 +33,13 @@ 34sns-repair-1n-1f 35m0singlenode 36spare-reservation +# 37protocol ST checks checksum of the BE structures during +# developmental phase they are bound to fail so code +# changes are required but ST has to be in disabled +# state for now when the release is in GA phase we will +# enable the ST again to ensure there will be no changes +# in BE structures. + 37protocol 51kem) # libisal does not need kernel based ST From 2d61ad1ecdf59020905035906daa18de0014bf1a Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Wed, 3 Aug 2022 01:10:50 -0600 Subject: [PATCH 2/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- st/protocol | 4 ++++ utils/functions | 7 ------- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/st/protocol b/st/protocol index 7e6ad8e154e..1964312137b 100755 --- a/st/protocol +++ b/st/protocol @@ -58,6 +58,10 @@ popd echo "Comparing '$proto_dev' and '$proto_current' files" $diff_cmd $proto_dev $proto_current exit_code=$? +if [ $exit_code -ne 0 ]; then + echo -n "37protocol ST may fail if there are some local changes done to" + echo " the BE structures and such failures can be safely ignored." +fi # remove test files rm -rf $test_dir 2>&1> /dev/null diff --git a/utils/functions b/utils/functions index 059220f9b77..c66a933a012 100755 --- a/utils/functions +++ b/utils/functions @@ -33,13 +33,6 @@ 34sns-repair-1n-1f 35m0singlenode 36spare-reservation -# 37protocol ST checks checksum of the BE structures during -# developmental phase they are bound to fail so code -# changes are required but ST has to be in disabled -# state for now when the release is in GA phase we will -# enable the ST again to ensure there will be no changes -# in BE structures. - 37protocol 51kem) # libisal does not need kernel based ST From 95f5bfc4c87270857000bad729b942755035d42d Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Wed, 3 Aug 2022 01:51:04 -0600 Subject: [PATCH 3/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- .xperior/testds/motr-single_tests.yaml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.xperior/testds/motr-single_tests.yaml b/.xperior/testds/motr-single_tests.yaml index 9cc8eef7cfc..ca9e4dc42bd 100644 --- a/.xperior/testds/motr-single_tests.yaml +++ b/.xperior/testds/motr-single_tests.yaml @@ -490,12 +490,13 @@ Tests: - id : 37protocol script : 'm0 run-st 37protocol' dir : src/scripts - # this ST checks checksum of the BE structures during - # developmental phase they are bound to fail so code - # changes are required but ST has to be in disabled - # state for now when the release is in GA phase we will - # enable the ST again to ensure there will be no changes - # in BE structures. + # this ST confirms that no BE structures are changed + # in the new version of the code since that would + # create a mismatch of BE structures and thus cause + # corruption in case of upgrades. During development + # phase the BE structures are assumed to be modified + # and to avoid this ST from failing it is better to disable + # the ST until a GA release is done executor : Xperior::Executor::Skip sandbox : /var/motr/root/sandbox.st-37protocol groupname: 01motr-single-node From e1f9b32d7e69527602c698950f018d8119a071b8 Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Wed, 3 Aug 2022 04:51:53 -0600 Subject: [PATCH 4/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- .xperior/testds/motr-single_tests.yaml | 2 +- st/protocol | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.xperior/testds/motr-single_tests.yaml b/.xperior/testds/motr-single_tests.yaml index ca9e4dc42bd..aa04fa30ba2 100644 --- a/.xperior/testds/motr-single_tests.yaml +++ b/.xperior/testds/motr-single_tests.yaml @@ -490,7 +490,7 @@ Tests: - id : 37protocol script : 'm0 run-st 37protocol' dir : src/scripts - # this ST confirms that no BE structures are changed + # This ST confirms that no BE structures are changed # in the new version of the code since that would # create a mismatch of BE structures and thus cause # corruption in case of upgrades. During development diff --git a/st/protocol b/st/protocol index 1964312137b..42f724a268e 100755 --- a/st/protocol +++ b/st/protocol @@ -59,8 +59,9 @@ echo "Comparing '$proto_dev' and '$proto_current' files" $diff_cmd $proto_dev $proto_current exit_code=$? if [ $exit_code -ne 0 ]; then - echo -n "37protocol ST may fail if there are some local changes done to" - echo " the BE structures and such failures can be safely ignored." + echo -n "37protocol ST may fail if there are some local changes done to " + echo -n "the BE structures. please confirm these are intended changes to " + echo "the BE structures in the new version before ignoring this error" fi # remove test files From da5d4727a8ac0346a5d4b16ed0aa072f600c2916 Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Wed, 3 Aug 2022 10:26:22 -0600 Subject: [PATCH 5/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- st/protocol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st/protocol b/st/protocol index 42f724a268e..4d707f6f051 100755 --- a/st/protocol +++ b/st/protocol @@ -60,7 +60,7 @@ $diff_cmd $proto_dev $proto_current exit_code=$? if [ $exit_code -ne 0 ]; then echo -n "37protocol ST may fail if there are some local changes done to " - echo -n "the BE structures. please confirm these are intended changes to " + echo -n "the BE structures. Please confirm these are intended changes to " echo "the BE structures in the new version before ignoring this error" fi From 710d591303f9443a3238c5990696cd88ddb4d572 Mon Sep 17 00:00:00 2001 From: Prasanna Kulkarni Date: Thu, 4 Aug 2022 00:17:03 -0600 Subject: [PATCH 6/6] CORTX-33718: Disable 37protocol till release time Problem: 37protocol ST checks checksum of the BE structures during developmental phase they are bound to fail as structures may change so codechanges are required but ST has to be in disabled state for now when the release is in GA phase we will enable the ST again to ensure there will be no changes in BE structures. Solution: Disable 37protocol till release time Signed-off-by: Prasanna Kulkarni --- .xperior/testds/motr-single_tests.yaml | 2 +- st/protocol | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.xperior/testds/motr-single_tests.yaml b/.xperior/testds/motr-single_tests.yaml index aa04fa30ba2..f301cd8983e 100644 --- a/.xperior/testds/motr-single_tests.yaml +++ b/.xperior/testds/motr-single_tests.yaml @@ -496,7 +496,7 @@ Tests: # corruption in case of upgrades. During development # phase the BE structures are assumed to be modified # and to avoid this ST from failing it is better to disable - # the ST until a GA release is done + # the ST until a GA release is done. executor : Xperior::Executor::Skip sandbox : /var/motr/root/sandbox.st-37protocol groupname: 01motr-single-node diff --git a/st/protocol b/st/protocol index 4d707f6f051..1b10ef68270 100755 --- a/st/protocol +++ b/st/protocol @@ -61,7 +61,7 @@ exit_code=$? if [ $exit_code -ne 0 ]; then echo -n "37protocol ST may fail if there are some local changes done to " echo -n "the BE structures. Please confirm these are intended changes to " - echo "the BE structures in the new version before ignoring this error" + echo "the BE structures in the new version before ignoring this error." fi # remove test files