(3.3.2) The message #rfc2965String is sent but not implemented in GemStone 3.4.3

[dalehenrich]

Just did a local test run where I check for sent but not implemented as well as undefined globals and it turned up the fact that #rfc2965String is sent but not implemented ... probably should add the sent but not implemented and undefined globals tests to at least the GemStone tests while we're addressing this missing method ...

[dalehenrich]

Hmmm, things are a bit more complicated:

1. WAFastCGIAdaptor>>addCookieRFC2965:toStream: is not actually sent from anywhere within Seaside
2. WACookie>>rfc6265String is implemented, but the comment in the method refers to the class comment which refers to RFC2965 and no reference to RFC6265:

   Cookie spec
   http://tools.ietf.org/html/rfc2109
   
   Cookie 2 spec
   http://tools.ietf.org/html/rfc2965
   

3. A grep on rfc2965String does not show any implementors for the other platforms:

   grep -s rfc2965String */*/*/*
   Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookieRFC2965.toStream..st:		nextPutAll: aWACookie rfc2965String;
   Seaside-Core.package/WACookie.class/class/combine.using..st:	it is supposed to send one of #oldNetscapeString #rfc2109String #rfc2965String to the argument"
   Seaside-Pharo-Slime.package/WACookieConversionRule.class/instance/initialize.st:		replace: '``@a rfc2965String' with: '``@a rfc6265String'
   Seaside-Pharo-Slime.package/WACookieConversionRule.class/instance/name.st:	^ '#oldNetscapeString, #rfc2109String and #rfc2965String have been replaced with #rfc6265String'
   Seaside-Pharo-Slime.package/WACookieConversionRule.class/instance/rationale.st:	^ '#oldNetscapeString, #rfc2109String and #rfc2965String have been replaced by #rfc6265String.'
   Seaside-Slime.package/WACookieConversionRule.class/instance/initialize.st:		replace: '``@a rfc2965String' with: '``@a rfc6265String'
   Seaside-Slime.package/WACookieConversionRule.class/instance/name.st:	^ '#oldNetscapeString, #rfc2109String and #rfc2965String have been replaced with #rfc6265String'
   Seaside-Slime.package/WACookieConversionRule.class/instance/rationale.st:	^ '#oldNetscapeString, #rfc2109String and #rfc2965String have been replaced by #rfc6265String.'
   Seaside-Tests-Slime.package/WASlimeTest.class/instance/testCookieConversionRule.st:	self compile: 'method3 WACookie new rfc2965String' in: class.
   

Since there are no tests for #addCookieRFC2965:toStream: it might make sense to simply remove the method completely?

@jbrichau or @marschall, do you have any light to shed on this?

[dalehenrich]

Okay ... the GemStone tests are now all failing with SentButNotImplemented errors, so we can avoid these in the future ...

[dalehenrich]

It seems that https://tools.ietf.org/html/rfc2965 was obsoleted by https://tools.ietf.org/html/rfc6265 ... so it seems to be appropriate the use the #rfc6265String message, but I'm also inclined to change the name of WAFastCGIAdaptor>>addCookieRFC2965:toStream: to WAFastCGIAdaptor>>addCookieRFC6265:toStream: and have #addCookieRFC2965:toStream: call #addCookieRFC6265:toStream: ...

I'll make these changes and get the tests passing, open a pull request and then let you guys make the final decision...