WAFastCGIAdaptor doesn’t write cookie attributes ‘Max-Age’ and ‘SameSite’

[Rinzwind]

On WACookie, #writeOn:, through #rfc6265String, writes out ‘Max-Age’ and ‘SameSite’ attributes:

Seaside/repository/Seaside-Core.package/WACookie.class/instance/rfc6265String.st

Lines 2 to 16 in c152487

	rfc6265String
	"Serializes the receiver according to RFC 6265.
	See class comment for a link to the spec."
	^ String streamContents: [ :stream |
	| useQuotes |
	"the spec allows us to quote but we don't know how good browser support is"
	useQuotes := false.
	self writeKeyValueQuoted: useQuotes on: stream.
	self writeExpiresOn: stream.
	self writeMaxAgeQuoted: useQuotes on: stream.
	self writeDomainQuoted: useQuotes on: stream.
	self writePathQuoted: useQuotes on: stream.
	self writeSecureOn: stream.
	self writeHttpOnlyOn: stream.
	self writeSameSiteOn: stream ]

But on WAFastCGIAdaptor, #addCookie:toStream: does not write out those attributes:

Seaside/repository/Seaside-Adaptors-FastCGI.package/WAFastCGIAdaptor.class/instance/addCookie.toStream..st

Lines 12 to 17 in c152487

	aWACookie
	writeExpiresOn: aStream;
	writePathQuoted: false on: aStream;
	writeDomainQuoted: false on: aStream;
	writeSecureOn: aStream;
	writeHttpOnlyOn: aStream.

I’m not sure why it doesn’t just use the WACookie’s #writeOn:.

[jbrichau]

The change to rfc6265 was never properly implemented in the FastCGI adapter. The current code is there because of #1115

It seems we should indeed simply call writeOn: and remove the old code.

[jbrichau]

In #1378, I call the rfc6265String because this is also the method being used in the Zinc Adapter.