Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use #document:mimeType: when mime type is nil #707

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Closed

don't use #document:mimeType: when mime type is nil #707

GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Grease-Pharo-Core-lr.45 needs to be merged from Seaside 3.0. It fixes some 
typical uses of Seaside-REST. We should also come up with some unit tests to 
reproduce the issue.

Original issue reported on code.google.com by philippe...@gmail.com on 22 Jan 2012 at 4:32

@GoogleCodeExporter
Copy link
Author

I think I know what the issue is, if you implement something like this:

index
    <get>
    ^ 'ok'

It will fail because WAResponse >> #document:mimeType: triggers WAMimeDocument 
>> #mimeType: with a nil argument with default to WAMimeType 
applicationOctetStream which answers #isBinary with true.

I think we should default to WAMimeType applicationOctetStream for Strings

Original comment by philippe...@gmail.com on 18 Feb 2012 at 10:07

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Investigating further #executeResult: is problematic because it sends 
#document:mimeType: even if the mime type is nil with overrides the default 
mime type of the collection.

Original comment by philippe...@gmail.com on 19 Feb 2012 at 10:05

  • Changed title: don't use #document:mimeType: when mime type is nil
  • Changed state: Started
  • Added labels: REST, Type-CleanUp
  • Removed labels: Type-Task

@GoogleCodeExporter
Copy link
Author

Investigating further #executeResult: is problematic because it sends 
#document:mimeType: even if the mime type is nil with overrides the default 
mime type of the collection.

Original comment by philippe...@gmail.com on 19 Feb 2012 at 10:05

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: Seaside-REST-Core-pmm.44
Author: pmm
Time: 19 February 2012, 11:06:39 am
UUID: edfbe879-390b-47f8-82e4-64e13885916e
Ancestors: Seaside-REST-Core-pmm.43

- Issue 707:    don't use #document:mimeType: when mime type is nil
- http://code.google.com/p/seaside/issues/detail?id=707

Name: Seaside-Tests-REST-Core-pmm.26
Author: pmm
Time: 19 February 2012, 11:07:14 am
UUID: 05f0f231-f2e3-4162-affe-5bf0be628947
Ancestors: Seaside-Tests-REST-Core-pmm.25

- Issue 707:    don't use #document:mimeType: when mime type is nil
- http://code.google.com/p/seaside/issues/detail?id=707

Original comment by philippe...@gmail.com on 19 Feb 2012 at 10:07

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant