Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the web tools in Pharo3 #780

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments
Closed

Fixes for the web tools in Pharo3 #780

GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

A trivial fix for Pharo 3:

In WAPharoInspector>>#evaluate #evaluatorClass has to be replaced with 
#compilerClass for the web based inspector to work.

I think this is OK for both Pharo 2.0 and 3.0

Sven

---
Another trivial fix for Pharo 3:

In WAVirtualMachineStatus>>#renderValuesOn: the modules lists should be asked 
using self image vm not self image.

This not an incompatibility between Pharo 2 and 3. Instead of creating a new 
package, it could also be fixed with a little dynamic hack.

Original issue reported on code.google.com by jo...@yesplan.be on 16 Feb 2014 at 1:10

@GoogleCodeExporter
Copy link
Author

Original comment by jo...@yesplan.be on 16 Feb 2014 at 1:44

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I'm not seeing the fix for WAVirtualMachineStatus, only for WAPharoInspector. 
Did you commit to the right repository?

Original comment by philippe...@gmail.com on 16 Feb 2014 at 10:22

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Err... yes it is in Seaside-Pharo20-Tools-Web-JohanBrichau.4:

ame: Seaside-Pharo20-Tools-Web-JohanBrichau.4
Author: JohanBrichau
Time: 16 February 2014, 2:44:22.716494 pm
UUID: 01ec38a2-da86-4da4-8e3e-1c798f624824
Ancestors: Seaside-Pharo20-Tools-Web-JohanBrichau.3

In WAVirtualMachineStatus>>#renderValuesOn: the modules lists should be asked 
using self image vm not self image.

https://code.google.com/p/seaside/issues/detail?id=780

thanks Sven!

Original comment by jo...@yesplan.be on 17 Feb 2014 at 6:13

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by jo...@yesplan.be on 17 Feb 2014 at 6:14

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Sorry, my bad, I looked in Seaside-Pharo-Tools-Web

Original comment by philippe...@gmail.com on 17 Feb 2014 at 11:16

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant