Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAHtmlAttributes >> #addClass: allocates too much #816

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments
Closed

WAHtmlAttributes >> #addClass: allocates too much #816

GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Yesplan reported that WAHtmlAttributes >> #addClass: allocates too much young 
space too quickly.

Original issue reported on code.google.com by philippe...@gmail.com on 18 Aug 2014 at 5:50

@GoogleCodeExporter
Copy link
Author

This is mostly an issue on GemStone/S

Original comment by philippe...@gmail.com on 19 Aug 2014 at 6:08

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: Seaside-Core-pmm.825
Author: pmm
Time: 19 August 2014, 9:03:15 am
UUID: cf2a81ae-e2e5-42e1-a40e-ad893b914a0a
Ancestors: Seaside-Core-pmm.824

Issue 816:  WAHtmlAttributes >> #addClass: allocates too much
 - no overhead for a single class
 - for multiple classes the overhead is
  * one object with two instance variables
  * one ordered collection
 - the full attribute value is never constructed as a string
 - use characters instead of strings where possible

Original comment by philippe...@gmail.com on 19 Aug 2014 at 8:08

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 22 Aug 2014 at 4:23

  • Added labels: Version-Seaside3.2
  • Removed labels: ****

@marschall marschall added this to the 3.2 milestone Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants