Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in Slime rules (due to code that was forgotten when moving from RB to Renraku framework) #1415

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix errors in Slime rules (due to code that was forgotten when moving from RB to Renraku framework) #1415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...110-Slime.package/WAChangesStateWhileRenderingRule.class/instance/afterCheck.mappings..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ afterCheck: aNode mappings: dict
aNode isWrite ifFalse: [ ^ false ].
(WASlime isWithinCallback: aNode) ifTrue:[ ^ false ].

^ true
^ aNode methodNode methodClass instVarNames includes: aNode name
4 changes: 4 additions & 0 deletions ...ide-Pharo110-Slime.package/WAUsesWrongRendererRule.class/instance/afterCheck.mappings..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
hooks
afterCheck: aNode mappings: dict

^ aNode arguments first references: aNode receiver leftmostChainReceiver name
10 changes: 9 additions & 1 deletion repository/Seaside-Tests-Slime.package/WASlimeTest.class/instance/testUsesWrongRenderer.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,12 @@ testUsesWrongRenderer
in: class.
self
assertRule: WAUsesWrongRendererRule
matches: { class>>#renderContentOn: }
matches: { class>>#renderContentOn: }.

self
compile: 'renderContentOn: html
html jQuery load html: [ :r | html div ]'
in: class.
self
assertRule: WAUsesWrongRendererRule
matches: { class>>#renderContentOn: }.
2 changes: 1 addition & 1 deletion repository/Seaside-Tests-Slime.package/monticello.meta/categories.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Seaside-Tests-Slime'!
self packageOrganizer ensurePackage: #'Seaside-Tests-Slime' withTags: #()!
Loading