Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling IPv6 on setup not idempotent #13098

Open
petiepooo opened this issue May 30, 2024 · 0 comments
Open

disabling IPv6 on setup not idempotent #13098

petiepooo opened this issue May 30, 2024 · 0 comments

Comments

@petiepooo
Copy link
Contributor

} >> /etc/sysctl.conf

These lines are added each time so-setup is run, meaning they are duplicated when so-setup is run multiple times. There should probably be a check for their presence first before adding them.

Alternatively, at least on debian/ubuntu systems, it's best practice to create a new file in the drop-in directory at /etc/sysctl.d/ instead of modifying the actual sysctl.conf file itself. That would prevent the need to check for presence first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant