Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakeEmailHandler for the CakePHP framework #162

Closed
wants to merge 2 commits into from
Closed

CakeEmailHandler for the CakePHP framework #162

wants to merge 2 commits into from

Conversation

jadb
Copy link

@jadb jadb commented Feb 13, 2013

Similar to Swift_Mailer but for CakePHP applications not to add yet another dependency. Can be used with the CakePHP Monolog plugin.

*/
class CakeEmailHandler extends MailHandler {

protected $_to;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the underscore.

@Seldaek
Copy link
Owner

Seldaek commented Feb 13, 2013

@jadb I don't really think it makes sense to have framework specific stuff in monolog itself. It should ideally sit in the framework code, if the framework supports monolog natively. Or as it seems to be the case here, I would suggest having this handler in your cakephp-monolog plugin.

@jadb
Copy link
Author

jadb commented Feb 13, 2013

@Seldaek ok - I guess you have a point. Closing this pull request then.

@jadb jadb closed this Feb 13, 2013
@Seldaek
Copy link
Owner

Seldaek commented Feb 13, 2013

Alright, one thing that we could do here (in the README or something) though is list monolog users and especially integrations with frameworks that exist. That would help discovery if a CakePHP user is looking here and doesn't know about your plugin. I'll take a look at that in a moment.

@Seldaek
Copy link
Owner

Seldaek commented Feb 13, 2013

@jadb
Copy link
Author

jadb commented Feb 13, 2013

Thanks, much appreciated. I updated the plugin as advised and it now supports all the other monolog vendor libraries of handlers, processors and formatters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants