From 9de989a63af3e656a0a2d24051e73ee2337b1c84 Mon Sep 17 00:00:00 2001 From: titusfortner Date: Tue, 31 Oct 2023 15:45:55 -0500 Subject: [PATCH] [rb] update guards for flaky tests --- .../integration/selenium/webdriver/remote/driver_spec.rb | 3 ++- .../integration/selenium/webdriver/remote/element_spec.rb | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb b/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb index c6e1931ae6113..ef697cca61717 100644 --- a/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb +++ b/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb @@ -31,7 +31,8 @@ module Remote expect(driver.status).to be_a(Hash) end - it 'uses a default file detector' do + it 'uses a default file detector', + flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do driver.navigate.to url_for('upload.html') driver.find_element(id: 'upload').send_keys(__FILE__) diff --git a/rb/spec/integration/selenium/webdriver/remote/element_spec.rb b/rb/spec/integration/selenium/webdriver/remote/element_spec.rb index d86a3c8502f56..1ee263251a9ab 100644 --- a/rb/spec/integration/selenium/webdriver/remote/element_spec.rb +++ b/rb/spec/integration/selenium/webdriver/remote/element_spec.rb @@ -31,7 +31,8 @@ module WebDriver end context 'when uploading one file' do - it 'uses the provided file detector', exclusive: {driver: :remote}, flaky: {browser: :safari, ci: :github} do + it 'uses the provided file detector', exclusive: {driver: :remote}, + flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do driver.navigate.to url_for('upload.html') driver.find_element(id: 'upload').send_keys('element_spec.rb') @@ -47,7 +48,8 @@ module WebDriver end context 'when uploading multiple files' do - it 'uses the provided file detector', exclusive: {driver: :remote}, flaky: {browser: :safari, ci: :github} do + it 'uses the provided file detector', exclusive: {driver: :remote}, + flaky: {browser: :safari, ci: :github, reason: 'unreliable with downloads'} do driver.navigate.to url_for('upload_multiple.html') driver.find_element(id: 'upload').send_keys("driver_spec.rb\nelement_spec.rb")