Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Replace https://github.com/asafh/jtoml as it has been abandoned #13538

Closed
diemol opened this issue Feb 2, 2024 · 4 comments · Fixed by #14470
Closed

[🚀 Feature]: Replace https://github.com/asafh/jtoml as it has been abandoned #13538

diemol opened this issue Feb 2, 2024 · 4 comments · Fixed by #14470

Comments

@diemol
Copy link
Member

diemol commented Feb 2, 2024

Feature and motivation

This TOML parser is used to read the configuration file in Grid, the code has been abandoned and it might have vulnerabilities.

Usage example

We could replace it with https://github.com/tomlj/tomlj, and it is the only one with recent releases.

Worst case, fork the one we use and update it.

@Delta456
Copy link
Contributor

I can work on this issue. Let's go with the tomlj/tomlj parser.

@Delta456
Copy link
Contributor

A warning for the upcoming change was added in 6b4c39c and Tomlj PR #14470 will be added after next two releases

@Delta456
Copy link
Contributor

Delta456 commented Nov 6, 2024

It is finally implemented with the help of @pujagani!

Copy link

github-actions bot commented Dec 6, 2024

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants