Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Remote content prevents icon from triggering dropdown #4041

Closed
nandastone opened this issue May 19, 2016 · 2 comments
Closed

[Dropdown] Remote content prevents icon from triggering dropdown #4041

nandastone opened this issue May 19, 2016 · 2 comments
Milestone

Comments

@nandastone
Copy link

nandastone commented May 19, 2016

This behaviour is observable in the documentation: http://semantic-ui.com/modules/dropdown.html#remote-content

To reproduce click the icon located in the right of the Dropdown before remote data has loaded. Nothing happens. Click anywhere else in the Dropdown to trigger the remote data load. Clicking the icon then works.

dropdown-remote-icon

The issue appears to be in the event handler for clicking the icon, which attempts to toggle the dropdown menu. This is prevented from happening if there are no child options or message in the dropdown, which is the case for a dropdown with remote data.

https://github.com/Semantic-Org/Semantic-UI/blob/2.1.8/src/definitions/modules/dropdown.js#L874-L879

I believe if the module.is.search() is true, it should work more like the text element handler:

https://github.com/Semantic-Org/Semantic-UI/blob/2.1.8/src/definitions/modules/dropdown.js#L880-L885

@jlukic jlukic added this to the 2.2.1 milestone May 20, 2016
@jlukic
Copy link
Member

jlukic commented May 20, 2016

Clicking the icon should focus the field in this case causing the dropdown to query for content.

@jlukic jlukic modified the milestones: 2.2.3, 2.2.4 Aug 22, 2016
@jlukic jlukic modified the milestones: 2.2.5, 2.2.6, 2.2.7 Oct 28, 2016
jlukic added a commit that referenced this issue Dec 29, 2016
@jlukic
Copy link
Member

jlukic commented Dec 29, 2016

Fixed in 2.2.8, show will now always query if no results and remote. Also solves #4041

@jlukic jlukic closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants