Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burned items should be greyed out in Kanji Composition accordion #131

Open
wrex opened this issue Mar 31, 2023 · 2 comments
Open

Burned items should be greyed out in Kanji Composition accordion #131

wrex opened this issue Mar 31, 2023 · 2 comments

Comments

@wrex
Copy link
Collaborator

wrex commented Mar 31, 2023

Currently only the meaning and reading are greyed:

Screenshot 2023-03-31 at 1 50 25 PM

The kanji itself should also used the --ED-text-greyed text color.

@shdwns
Copy link

shdwns commented Apr 1, 2023

Along with this, i think the new item mark is also supposed to be orange
image

@wrex
Copy link
Collaborator Author

wrex commented Apr 1, 2023

i think the new item mark is also supposed to be orange

We don't currently have a properties defined for the new/active/burned badge colors (locked has an effect applied), but probably should.

We use the "brand" color for that 新 badge currently. Unfortunately, in the default WKED colors, the "brand" color and the "kanji" color are the same. With my override colors it looks like this:

Screenshot 2023-04-01 at 9 38 15 AM

Let me think about this a bit. The "brand" color isn't really used very much, nor is it used consistently. It should probably be replaced.

I'm leaning toward getting rid of --ED-brand and replacing it with two properties:

  • --ED-badge-new (for the 新 badge bg ... locked is handled, active is normal, and burned is/should-be handled). Sadly, they don't actually add a badge for burned or locked so they have to be handled differently.
  • --ED-chrome --ED-nav-chrome for the accordion hide/expose triangles on the dashboard, the borders around things for tab navigation, etc., and maybe one or two other places.

Most sites I've built have a consistent "brand" color, but a functional site like this is a little different.

Currently, the review-forecast bars also use the --ED-brand color. I'm undecided if they should become --ED-chrome or --ED-progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants