Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend_Validate_Hostname and new TLD #68

Closed
borissov opened this issue May 8, 2020 · 2 comments
Closed

Zend_Validate_Hostname and new TLD #68

borissov opened this issue May 8, 2020 · 2 comments

Comments

@borissov
Copy link

borissov commented May 8, 2020

Hello,
Hostname validator not support a lot of top level domains. In my opinion is so confusing and overloaded. This validator is used also in email validator. I think simpler validator may be is better.
What is your opinion?

P.S. Sorry for my bad English.

@Shardj
Copy link
Owner

Shardj commented May 12, 2020

I agree it's quite bad, personally I use jeremykendall's php-domain-parser https://github.com/jeremykendall/php-domain-parser to do all of this. I highly recommend you change over to using that or similar instead.

However, this repo isn't here to try and give zf1 new life. It's just to support those who are stuck on this framework, adding new features or changing things is pointless as people should be trying to leave this repo not stay on it. You're far better off using other libraries to fill in holes where zf1's existing functionality is lacking.

@Shardj
Copy link
Owner

Shardj commented Jun 6, 2020

Seems this guy has made a PR with what you need #72

Well, at least it fixes the TLDs for now

@Shardj Shardj closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants