Allow using hosted Redis instances by default #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hosted Redis servers use self signed certificates (because they do not own the domain they're running on such as `compute-1.amazonaws.com`) therefore a full SSL connection verification will fail. The fix for that behavior is to disable verification so a self signed certificate can be used [docs from a hosted Redis/Key-value store provider](https://devcenter.heroku.com/articles/connecting-heroku-redis#connecting-in-ruby). This PR makes the default behavior to allow connecting to self signed Redis servers. This failing SSL connection behavior was originally reported in Shopify#292, however that issue focuses on raising visibility of such failures. This is an alternative to Shopify#293 that does not introduce a new configuration flag.
|
I'm testing this internally quickly but looks good to me. Sorry for the delay. |
|
Worked, thanks! I will cut a release shortly. |
|
Thank you! |
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Dec 3, 2024
Should work on hosted redis now Shopify/ci-queue#294
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Dec 5, 2024
Should work on hosted redis now Shopify/ci-queue#294
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Dec 5, 2024
Should work on hosted redis now Shopify/ci-queue#294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosted Redis servers use self signed certificates (because they do not own the domain they're running on such as
compute-1.amazonaws.com) therefore a full SSL connection verification will fail. The fix for that behavior is to disable verification so a self signed certificate can be used docs from a hosted Redis/Key-value store provider.This PR makes the default behavior to allow connecting to self signed Redis servers.
This failing SSL connection behavior was originally reported in #292, however that issue focuses on raising visibility of such failures.
This is an alternative to #293 that does not introduce a new configuration flag.