We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the current behavior
When you add a button block and remove the label, an empty button appears.
Describe the expected behavior
No button when button label is empty. The Image with text section has a button block and a check to not show the button when the label is empty.
Version information (Dawn, browsers and operating systems)
Possible solution
I'll need to add the following condition for the rich text button block:
{%- if block.settings.button_label != blank -%} <a{% if block.settings.button_link == blank %} role="link" aria-disabled="true"{% else %} href="{{ block.settings.button_link }}"{% endif %} class="button{% if block.settings.button_style_secondary %} button--secondary{% else %} button--primary{% endif %}" {{ block.shopify_attributes }}> {{ block.settings.button_label | escape }} </a> {%- endif -%}
Additional context/screenshots
Rich text - empty button label
Image with text - empty button label
Related: #1460
The text was updated successfully, but these errors were encountered:
andrewetchen
Successfully merging a pull request may close this issue.
Describe the current behavior
When you add a button block and remove the label, an empty button appears.
Describe the expected behavior
No button when button label is empty. The Image with text section has a button block and a check to not show the button when the label is empty.
Version information (Dawn, browsers and operating systems)
Possible solution
I'll need to add the following condition for the rich text button block:
Additional context/screenshots
Rich text - empty button label
Image with text - empty button label
Related: #1460
The text was updated successfully, but these errors were encountered: