You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version information (Dawn, browsers and operating systems)
Dawn Version: 8.0.0-rc
Chrome Version 109.0.5414.87
macOS Version 13.0.1
Possible solution
Prevent "enter" from submitting the form
Additional context/screenshots
Video demonstrating current behaviour
screencast.2023-01-23.12-16-31.mp4
Video demonstrating browser input validation
If the quantity entered does not respect the input's min, max attributes a browser validation error may also appear/flash (instead to redirecting to checkout).
screencast.2023-01-23.12-17-33.mp4
Note: keep a11y concerns in mind when fixing this
The text was updated successfully, but these errors were encountered:
I feel like we had a discussion about this before and pressing enter within a form should submit it. As the expected behaviour 🤔 Brought up here but I think since we do have a submit button in the form it could be ok. Maybe something to confirm with some of our accessibility experts.
@ludoboludo thanks for this context! Definitely will have to keep a11y in mind. Created this issue because a few folks have flagged the form submission while editing quantity as "unexpected" behaviour, so just want us to revisit this. Additionally the flashing of browser min/max validation as a side-effect is something we'd ideally want to avoid as well.
KaichenWang
changed the title
[Cart] Pressing "enter" in quantity field submits submits form and redirects to checkout
[Cart] Pressing "enter" in quantity field submits form and redirects to checkout
Feb 3, 2023
Describe the current behavior
Describe the expected behavior
Version information (Dawn, browsers and operating systems)
Possible solution
Prevent "enter" from submitting the form
Additional context/screenshots
Video demonstrating current behaviour
screencast.2023-01-23.12-16-31.mp4
Video demonstrating browser input validation
If the quantity entered does not respect the input's
min
,max
attributes a browser validation error may also appear/flash (instead to redirecting to checkout).screencast.2023-01-23.12-17-33.mp4
Note: keep a11y concerns in mind when fixing this
The text was updated successfully, but these errors were encountered: