Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image with text] Reveal in cascade for overlap content layout #2375

Closed
melissaperreault opened this issue Mar 9, 2023 · 2 comments
Closed

[Image with text] Reveal in cascade for overlap content layout #2375

melissaperreault opened this issue Mar 9, 2023 · 2 comments
Assignees
@ludoboludo
Labels
Category: Enhancement New feature or request

Comments

@melissaperreault
Copy link
Contributor

melissaperreault commented Mar 9, 2023 •
edited
Loading

Context

Recap of what I propose

  • No overlap content layout: Reveal image and content container background together, than the content blocks
  • Overlap content layout: Reveal each side individually

@melissaperreault, @kjellr this sounds like a great idea and I don't image it would be difficult to do. However, we don't have the "cascading" CSS in this PR, and adding that would change the scope a bit. The CSS that will handle delayed animation will be part of this PR (draft) and will need to be reviewed and tested before we can introduce it into other sections.

Originally posted by @metamoni in #2362 (comment)
@melissaperreault melissaperreault mentioned this issue Mar 9, 2023
Merged
14 tasks
@ludoboludo ludoboludo mentioned this issue Apr 24, 2023
Closed
8 tasks
@ludoboludo
Copy link
Contributor

We decided to not go ahead with this change as mentioned in this comment of the PR.

Maybe we should close the issue as well ?

@kjellr
Copy link
Contributor

kjellr commented Apr 28, 2023

Sure, that sounds good for now. We can always re-open later if we'd like. 👍

@kjellr kjellr closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludoboludo ludoboludo

Labels
Category: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Image with text] Add slide-in animation to the text content when set to overlap Shopify/dawn
3 participants
@kjellr @melissaperreault @ludoboludo