Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu drawer focus not trapped #2496

Open
kmeleta opened this issue Apr 5, 2023 · 1 comment
Open

Menu drawer focus not trapped #2496

kmeleta opened this issue Apr 5, 2023 · 1 comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Severity: 4

Comments

@kmeleta
Copy link
Contributor

kmeleta commented Apr 5, 2023

Describe the current behavior

The focus trap used in the menu drawer breaks in several scenarios and allows focus to escape outside the dialog. It appears to occur when..

  • when no localizations selects or social links are present
  • when no localizations, no social links, and account link is present but hidden (for tablet/desktop)

https://screenshot.click/05-30-cea10-p4hnd.mp4

Describe the expected behavior

Focus should always be trapped in the drawer and return to the menu toggle when tabbing past the last focusable item.

Version information (Dawn, browsers and operating systems)

Noticed on Dawn 8.0.0

Possible solution

The elements in the localization disclosures are being recognized as the last focusable item in the dialog, rather than the parent element or triggering button.

The account button can also get recognized as the last element even when it is hidden (the issue wouldn't occur on mobile when the account button becomes visible).

@kmeleta
Copy link
Contributor Author

kmeleta commented Apr 5, 2023

Related to or possibly a duplicate of #360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Category: Bug Something isn't working Severity: 4
Projects
None yet
Development

No branches or pull requests

2 participants