Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global] Homepage sections generate multiple links with similar text #603

Closed
svinkle opened this issue Sep 9, 2021 · 0 comments · Fixed by #1733
Closed

[Global] Homepage sections generate multiple links with similar text #603

svinkle opened this issue Sep 9, 2021 · 0 comments · Fixed by #1733
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 2 Affects some merchants/buyers Effort: Medium Severity: 3 Normal/Low Severity

Comments

@svinkle
Copy link
Member

svinkle commented Sep 9, 2021

Issue summary

When specific sections are on the homepage, there exists the possibility of many "View all" links. When navigating via link elements alone, screen reader users will hear "View all" link repeated which may give the impression each points to the same location. This could lead to a confusing user experience.

Screenshots

(Screenshot Removed)

Current code

HTML

<a href="/blogs/news" class="blog__button button">View all</a>

Steps to reproduce

  1. Go to a Dawn store with any supported browser
  2. With an active screen reader, navigate via links only

Behavior

Expected

  • "View all" links to be accompanied by additional information for context.

Actual

  • "View all" links do not contain additional context.

Recommendation

  1. Add a unique id to the section heading.
  2. Add a unique id to the "View all" link.
  3. Add the aria-labelledby attribute to the "View all" link, setting its value to its own id first, then the id of the heading, separated by a space.

With this change:

  • Screen readers will hear, "View all Blog posts, link", providing more context for each instance.

Recommended code

HTML

<h2 class="blog__title" id="SectionHeading-0">Blog posts</h2>

<!-- … -->

<a href="/blogs/news" class="blog__button button" id="ViewAll-0" aria-labelledby="ViewAll-0 SectionHeading-0">View all</a>

Specifications

@svinkle svinkle added Severity: 3 Normal/Low Severity Category: Accessibility Bugs found while using assistive technology Effort: Medium labels Sep 9, 2021
@svinkle svinkle added the Critical Path: 2 Affects some merchants/buyers label Nov 26, 2021
@svinkle svinkle mentioned this issue Mar 8, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Accessibility Bugs found while using assistive technology Critical Path: 2 Affects some merchants/buyers Effort: Medium Severity: 3 Normal/Low Severity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant