Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrect should not run on files where ParserError fails #303

Open
TastyPi opened this issue Jan 30, 2023 · 0 comments
Open

Autocorrect should not run on files where ParserError fails #303

TastyPi opened this issue Jan 30, 2023 · 0 comments

Comments

@TastyPi
Copy link

TastyPi commented Jan 30, 2023

I had a file that failed the ParserError check while running with autocorrect, and another lint removed some code in the file after the parser error. I didn't realise the code was removed until submitting the code for review and checking the diff.

I then went back to what I had before running erblint, fixed the ParserError first, then ran autocomplete, and it worked correctly. It would be nice if erblint checked ParserError first and, if that fails, don't bother with the other lints as they're likely to run into parsing errors too. At the very least it shouldn't autocomplete anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant