Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rules that enforce testing best practises #120

Closed
1 of 4 tasks
cartogram opened this issue Oct 13, 2018 · 1 comment
Closed
1 of 4 tasks

Add more rules that enforce testing best practises #120

cartogram opened this issue Oct 13, 2018 · 1 comment
Assignees
Labels
enhancement Package: eslint-plugin stale Stale issue that hasn't received any attention in a while

Comments

@cartogram
Copy link
Contributor

I think most things here can be turned into a rule. https://github.com/Shopify/web-foundation/blob/master/handbook/Best%20practices/Jest.md#best-practices

  • no-snapshots
  • mock-order
  • mock-full-module
  • no-bad-mock-features
@alexandcote alexandcote transferred this issue from Shopify/eslint-plugin-shopify Mar 27, 2020
@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue that hasn't received any attention in a while label Sep 12, 2020
@stale stale bot closed this as completed Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Package: eslint-plugin stale Stale issue that hasn't received any attention in a while
Projects
None yet
Development

No branches or pull requests

3 participants