Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional assignments #100

Closed
GoodForOneFare opened this issue May 23, 2016 · 1 comment
Closed

Fix conditional assignments #100

GoodForOneFare opened this issue May 23, 2016 · 1 comment

Comments

@GoodForOneFare
Copy link
Member

The operation.done callback contains this CoffeeScript assignment:

      if @nextPageParams?
        @title = "Load next #{@LARGE_PAGE_SIZE} products"

The transformed JS is missing a this.title assignment:

      if (this.nextPageParams != null) {
        this.nextPageParams;
      }
@GoodForOneFare
Copy link
Member Author

A couple of other affected files:

bulk_operations.coffee

data['value'] = operationData if operationData?
if (operationData != null) {
  operationData;
}

two_factor_auth.coffee:

password = $(form).find('input[name=password]').val()
@password = password if password?
var password = $(form).find('input[name=password]').val();

if (password != null) {
  password;
}

@GoodForOneFare GoodForOneFare changed the title Fix missing assignment in collection-products Decaf: Fix conditional assignments May 23, 2016
@GoodForOneFare GoodForOneFare changed the title Decaf: Fix conditional assignments Fix conditional assignments May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants