Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esify may be causing resource exhaustion #162

Closed
GoodForOneFare opened this issue Jun 13, 2016 · 2 comments · Fixed by #177
Closed

esify may be causing resource exhaustion #162

GoodForOneFare opened this issue Jun 13, 2016 · 2 comments · Fixed by #177
Assignees
@lemonmade
Labels
bug

Comments

@GoodForOneFare
Copy link
Member

While running the esify@12.2.0, zsh stops functioning with fork failed: resource temporarily unavailable, and Atom can't to open new windows.

Eyeballing recent changes, I'm guessing runESLint and/or findESLintBinary is opening more file descriptors than anticipated.

(Or I could be completely wrong, and I just have to reboot my computer :/ )
@GoodForOneFare
Copy link
Member Author

Commented out runESLint and things are speedy again. If the binary can be looked up once then reused, I think things'll improve.

@lemonmade is programmatically calling eslint+fix without proc.exec possible?

@lemonmade
Copy link
Member

Totally possible, I will look into it.

@lemonmade lemonmade self-assigned this Jun 13, 2016
@lemonmade lemonmade added the bug label Jun 13, 2016
@lemonmade lemonmade mentioned this issue Jun 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lemonmade lemonmade

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ESLint resource hogging Shopify/javascript
2 participants
@GoodForOneFare @lemonmade