-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timeout in CI and enable verbose tests for truffleruby #217
Add a timeout in CI and enable verbose tests for truffleruby #217
Conversation
eregon
commented
Mar 11, 2024
- To investigate hangs like https://github.com/Shopify/liquid-c/actions/runs/8191329021/job/22400306482
So https://github.com/Shopify/liquid-c/actions/runs/8235861511/job/22520963167?pr=217 failed after:
Unfortunately we don't see the started & hanging test due to I guess some flushing issue of GitHub Actions on cancellation (TruffleRuby does not buffer writes so that cannot be the issue). |
Running locally on truffleruby-dev, the test that hangs seems to be various tests of
|
4cb5322
to
1defef0
Compare
I have tried |
Attaching with
So it sounds like an unbounded loop while in the C extension.
|
My guess is oracle/truffleruby@b7cb26e is what broke this. |
I agree, this is a bug in liquid-c. This should be pretty simple to fix, can you send a PR? |
Confirmed that describe "rb_str_capacity" do
it "returns 0 for empty String" do
@s.rb_str_capacity("").should == 0
end
it "returns 1 for 'a'" do
@s.rb_str_capacity("a").should == 1
end
end passes on truffleruby but "fails" on CRuby which returns |
@peterzhu2118 I added a commit to this PR, could you review it? |
Thank you for debugging and the fix! |