Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating extension 'Shopify.polaris-for-vscode' failed: Cannot find module 'vscode-languageclient/node' #12780

Open
n-for-all opened this issue Oct 15, 2024 · 4 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@n-for-all
Copy link

Summary

Rinstalling the extension didn't work

how can i resolve this, it is a fresh installation of vscode om macbook Sonoma

Expected behavior

No response

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Description of what the gif shows

Steps to reproduce

Link to sandbox
1.
2.
3.

Are you using React components?

None

Polaris version number

0.9.8

Browser

No response

Device

No response

@n-for-all n-for-all added Bug Something is broken and not working as intended in the system. untriaged labels Oct 15, 2024
@WebX47
Copy link

WebX47 commented Dec 1, 2024

@n-for-all faced the same issue so built this unofficial one https://github.com/WebX47/Polaris-Companion feel free to use it if needed.

@n-for-all
Copy link
Author

thankyou

@yangwooseong
Copy link

@WebX47 What was the reason for error? I faced the same issue in the extension I'm working on, and I thought it was because all of the dependencies are ignored in the .vscodeignore. But your extension also ignores entire node_modules in .vscodeignore so I wonder how you fixed it.

@WebX47
Copy link

WebX47 commented Dec 2, 2024

Hey @yangwooseong, I'm using Bundler, so the final build file includes all the dependencies except for "VsCode." That's why I don’t want to add the node_module again since it's already in there. https://github.com/WebX47/Polaris-Companion/blob/main/esbuild.js

Hey @n-for-all, The tool now provides more precise suggestions by prioritizing tokens relevant to your input. For example, if you type "font-size," the suggestions will display font-size tokens first, rather than starting with unrelated keys like --p-font-family. Additionally, the detail window now shows both rem and px values for improved clarity, and the insert text has been updated to include var() for easier usage.

I haven't used the Polaris extension before, so I'm not sure how it used to function. But if you guys have any suggestions or need anything specific, just let me know.

Right now, I'm thinking about how I can integrate this with Tailwind or JSX/TSX. If everything goes well, I’ll likely publish the extension for easier updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

3 participants