Respect prefix in enable cookie route

[timolins]

Overview

The redirect introduced with #1022 doesn't apply the prefix. This means all requests get forwarded to /auth instead of /my-prefix/auth.

Consuming repo

What repo were you working in when this issue occurred?

koa-shopify-auth

[timolins]

Any updates on this? #1149 fixes this issue.

[scotttrinh]

@timolins

I think you need to sign the CLA to get your PR merged. I'm running into this issue now, too, and would love to help get this over the finish line.

[timolins]

I think you a right, but I wasn't able to find more information about this. They should probably add a few words about this in CONTRIBUTING.md.

[scotttrinh]

@timolins

If you click through the details on the failed check I think it'll walk you through it, but I haven't done it so it's a bit opaque to me, too. Definitely worth mentioning in the contribution guide!

[timolins]

Thanks for the hint! Just signed the CLA and the bot is happy now.

[eugene-kim]

I'm running into this issue as well and it's great see that there's a fix ready to go. Is there anything preventing the PR from being merged besides the review and the branches being out of sync?

[scotttrinh]

I have a fork with @timolins' fix merged published to npm while we're waiting if anyone here cares to use it. As soon as this lands in quilt, I plan on deprecating it, so if you're like me and just need to get it working, @cala/koa-shopify-auth can hold you over for now.

[junaid33]

Facing the same issue. @shopify/koa-shopify-auth works sometimes and sometimes it says page not found. This issue is causing our application to be rejected from the Shopify App Store. The package is updated but we are using a prefix.

[marutypes]

I believe this was fixed in #1440. Feel free to reopen if the issue persists.

[dooman87]

@TheMallen I believe this issue has been fixed only partially. I created a PR #1498 which should finally fix this. Appreciate if you could have a look.