bug: V5 MetadataRequest nullable topics array #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consulting the protocol guide the V5 request uses the same nullable array for topics as the V1-V4 requests. Improve existing unittest to properly exercise the encoding paths. Fixes #1352 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
|
Thank you! |
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Master rather than v1.22.0 as we need fix for sarama bug IBM/sarama#1353
Mongey
added a commit
to Mongey/terraform-provider-kafka
that referenced
this pull request
Apr 14, 2019
Master rather than v1.22.0 as we need fix for sarama bug IBM/sarama#1353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consulting the protocol guide the V5 request uses the same nullable
array for topics as the V1-V4 requests. Improve existing unittest to
properly exercise the encoding paths.
Fixes #1352