Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve NewMockListAclsResponse #1481

Merged
merged 4 commits into from
Sep 6, 2019
Merged

Improve NewMockListAclsResponse #1481

merged 4 commits into from
Sep 6, 2019

Conversation

agapoff
Copy link
Contributor

@agapoff agapoff commented Sep 5, 2019

This PR provides some improvements for NewMockListAclsResponse:

  1. It introduces support for ListAcls requests with Version = 1 (for Kafka 2+).
  2. It won't fail if ResourceName in request is not defined.
  3. It provides a more plausible response by setting some fields like Principal, Host, Operation, PermissionType.

@bai
Copy link
Contributor

bai commented Sep 6, 2019

Thank you! 💯

@bai bai merged commit 5534ffc into IBM:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai bai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agapoff @bai