Add GitHub Actions workflows, use golangci-lint #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun06
approved these changes
Jan 18, 2020
🚀 🚢 |
d1egoaz
reviewed
Jan 27, 2020
|
@d1egoaz this PR is ready for final review, please take a look when you have a chance 🙏 |
d1egoaz
approved these changes
Jan 28, 2020
.github/workflows/ci.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| go-version: [1.12.x, 1.13.x] | ||
| kafka-version: [2.3.1, 2.4.0] |
There was a problem hiding this comment.
do you think it'd be a good idea also to test against 2.2.x like previously travis did it with 2.2.1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use golangci-lint instead of assorted linters, apart from simplifying setup overall it'll allow running linters locally with a simple make lint. We still have a lot of linters disabled but otherwise there're too many failures. Will address those in a follow-up PR.
Build with GitHub Actions instead of Travis CI.
How to read this PR: first commit sets up GitHub Actions and golangci-lint, second commit fixes linter issues.
Interesting observation: GitHub Actions runs integration tests more than 2x faster compared to Travis.