consumer: bugfix for broker workers getting stuck #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| delete(c.brokerConsumers, broker) | ||
| if c.brokerConsumers[brokerWorker.broker] == brokerWorker { | ||
| delete(c.brokerConsumers, brokerWorker.broker) | ||
| } |
There was a problem hiding this comment.
So if I understand it correctly, this if case only triggers during a normal consumer shutdown? When we shut down because of a broker error, this delete will already have happened?
There was a problem hiding this comment.
It triggers when all PartitionConsumers move off of the brokerConsumer "safely", either via being closed or via a NotLeaderForPartition response. When the broker blows up we abort, and the delete happens immediately to prevent new partitions from taking a reference.
Very similar to #367 (on the producer): the consumer could have added new references to a brokerConsumer that was shutting down, leading it to spin with an error unnecessarily. Add a test for this case.
eapache
force-pushed
the
fix-consumer-references
branch
from
da3d3bc to
d988e6d
Compare
|
🆒 just was convincing myself what was going on here. |
eapache
added a commit
that referenced
this pull request
Mar 19, 2015
consumer: bugfix for broker workers getting stuck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #367 (on the producer): the consumer could have added new
references to a brokerConsumer that was shutting down, leading it to spin with
an error unnecessarily.
Add a test for this case.
@Shopify/kafka