producer: make Flush.Frequency behaviour better #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the timer would tick every Flush.Frequency regardless of if a message was actually queued. This meant that if no message arrived for Flush.Frequency then the next message would be sent immediately, which is unexpected if not *exactly* wrong. With this change the timer is only started when the first message arrives, and is cleared when a flush occurs. This should result in slightly better batching for low-volume topics at the result of slightly higher latency (although the delay will still never be more than Flush.Frequency).
| var ( | ||
| timer <-chan time.Time | ||
| buffer []*ProducerMessage | ||
| doFlush chan []*ProducerMessage |
|
Looks innocent enough to me :) |
eapache
added a commit
that referenced
this pull request
Mar 24, 2015
producer: make Flush.Frequency behaviour better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the timer would tick every Flush.Frequency regardless of if a message
was actually queued. This meant that if no message arrived for Flush.Frequency
then the next message would be sent immediately, which is unexpected if not
exactly wrong.
With this change the timer is only started when the first message arrives, and
is cleared when a flush occurs. This should result in slightly better batching
for low-volume topics at the result of slightly higher latency (although the
delay will still never be more than Flush.Frequency).
@Shopify/kafka