Refactor the producer, part 2 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eapache
force-pushed
the
producer-refactor-2
branch
from
381225c to
7c4ceb3
Compare
Merged
Second stand-alone chunk extracted from #544, (first chunk: #549). This uses the `produceSet` struct in the aggregator as well, and moves the `wouldOverflow` and `readyToFlush` methods to methods on the `produceSet`. Knock-on effects: - now that we do per-partition size tracking in the aggregator we can do much more precise overflow checking (see the compressed-message-batch-size-limit case in `wouldOverflow` which has changed) which will be more efficient in high-volume scenarios - since the produceSet encodes immediately, messages which fail to encode are now rejected from the aggregator and don't count towards batch size - we still have to iterate the messages in the flusher in order to reject those which need retrying due to the state machine; for simplicity I add them to a second produceSet still, which means all messages get encoded twice; this is a definite major performance regression which will go away again in part 3 of this refactor
eapache
force-pushed
the
producer-refactor-2
branch
from
7c4ceb3 to
733c74f
Compare
| @@ -320,7 +320,7 @@ func TestAsyncProducerEncoderFailures(t *testing.T) { | |||
| leader.Returns(prodSuccess) | |||
|
|
|||
| config := NewConfig() | |||
| config.Producer.Flush.Messages = 3 | |||
| config.Producer.Flush.Messages = 1 | |||
There was a problem hiding this comment.
This was needed because the 2 failed to encode messages are not counted towards the batch anymore I assume?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second stand-alone chunk extracted from #544, (first chunk: #549). This uses the
produceSetstruct in the aggregator as well, and moves thewouldOverflowandreadyToFlushmethods to methods on theproduceSet.Knock-on effects:
more precise overflow checking (see the compressed-message-batch-size-limit
case in
wouldOverflowwhich has changed) which will be more efficient inhigh-volume scenarios
now rejected from the aggregator and don't count towards batch size
which need retrying due to the state machine; for simplicity I add them to a
second produceSet still, which means all messages get encoded twice; this is
a definite major performance regression which will go away again in part 3
of this refactor
@wvanbergen