Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Client fails to start when apiKey is not provided for custom apps #782

Closed
korziee opened this issue Mar 21, 2023 · 4 comments
Closed

Client fails to start when apiKey is not provided for custom apps #782

korziee opened this issue Mar 21, 2023 · 4 comments
Labels

Comments

@korziee
Copy link

korziee commented Mar 21, 2023

Issue summary

  • @shopify/shopify-api version: 6.2.0
  • Node version: v18.14.0
  • Operating system: MacBook Pro 2021 M1

Client fails to start when apiKey is not provided for custom apps.

Expected behavior

Client allows apiKey to be undefined when isCustomStoreApp is provided.

Actual behavior

ShopifyError: Cannot initialize Shopify API Library. Missing values for: apiKey

Steps to reproduce the problem

  1. create an instance of the client without apikey and isCustomStoreApp:true
shopifyApi({
      apiSecretKey: "super secret",
      hostName: "my-shopify-shop.shopify.com",
      apiVersion: ApiVersion.January23,
      isEmbeddedApp: false,
      isCustomStoreApp: true,
    });

As far as I can tell the only value required for auth with custom apps is the "Admin API access token" (apiSecretKey in client)

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label May 21, 2023
@korziee
Copy link
Author

korziee commented May 24, 2023

not stale

@github-actions github-actions bot removed the Stale label May 24, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Jul 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as completed Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant