Allow variant inventory quantity #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
reviewed
Nov 13, 2020
andyw8
reviewed
Nov 13, 2020
paulomarg
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #801, Variant's
inventory_quantityis now a read-only field, and should be readable from the object.The PR allows
inventory_quantityto be filtered in as part of Variant's attributes. The field is only filtered out once variant is saved. User's will still be able to access theinventory_quantityfield as an attribute of Variant and from the json object both before and after a save.Also removed tests that are focused on deprecated versions, as well as the
allow_inventory_params?method since that was also based on deprecated versions of the API.