Avoid depending on ActiveSupport #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
Dec 14, 2020
| @@ -373,7 +375,7 @@ def setup | |||
| end | |||
|
|
|||
| test "raise error if timestamp is too old" do | |||
| params = { code: "any-code", timestamp: Time.now - 2.days } | |||
| params = { code: "any-code", timestamp: Time.now - 2 * SECONDS_IN_A_DAY } | |||
There was a problem hiding this comment.
Extremely nitpicky, but would it make sense to use Session.SECONDS_IN_A_DAY here?
There was a problem hiding this comment.
There's a couple of reasons why I usually avoid referencing a implementation's constants in the tests:
- If the constant is wrong in the implementation, and the test references that, then you lose out on the 'double-entry bookkeeping' safeguard of writing a test.
- If I choose to rename the constant, or move it somewhere else, the tests shouldn't break since the implementation hasn't changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #817 we ran into an issue relating to ActiveSupport not being loaded when updating to Rails 6.1.0. We only use it for some trivial time-related helpers – I think we can drop it completely.