Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is all of rails actually required? #1740

Open
RhysC opened this issue Oct 24, 2023 · 0 comments
Open

Is all of rails actually required? #1740

RhysC opened this issue Oct 24, 2023 · 0 comments

Comments

@RhysC
Copy link

RhysC commented Oct 24, 2023

Overview/summary

While I was looking to trim my Docker image down by reducing dependencies around unused parts of Rails I notice that shopify_app depends on all of rails, not just key parts.
Is this an accurate requirement or more of a connivence?
For example: I assume you don't need actionmailer, actionmailbox, actioncable as i cant see any of them used in the code base
NB the rails gem itself is just a collection of dependencies so we can clearly see what we need from there 🤷

I can see this issue too, but Im not sure if the rational is actually valid 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant