Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toxiproxy Server should exit with code 0 when SIGTERM'd #180

Closed
dlmiddlecote opened this issue May 25, 2017 · 3 comments
Closed

toxiproxy Server should exit with code 0 when SIGTERM'd #180

dlmiddlecote opened this issue May 25, 2017 · 3 comments
Labels
enhancement help wanted

Comments

@dlmiddlecote
Copy link
Contributor

Currently, when toxiproxy Server receives a SIGTERM signal (from docker stop say) it exits with a non-zero code.

Is this desired, or a feature? Could this be changed by handling a SIGTERM and exiting with 0?
@jpittis
Copy link
Contributor

jpittis commented May 25, 2017

I wouldn't say this is high priority but if this feature could be added without too much complexity, I can't think of why it wouldn't be appreciated.

@dlmiddlecote
Copy link
Contributor Author

I'll do this.

@dlmiddlecote dlmiddlecote mentioned this issue May 25, 2017
Merged
@jpittis
Copy link
Contributor

jpittis commented May 25, 2017

Thanks @dlmiddlecote <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpittis @dlmiddlecote