page:before-unload event not present

[lgo]

There were a number of events that Turbolinks fires but seem to have been pulled out of Turbograft (or these were added later into Turbolinks), one being page:before-unload. Are there any plans to add it, or alternatives?

[qq99]

Which ones are missing?

[pushrax]

We can probably just add any events you need.

[lgo]

It's no immediate problem since I've moved the project to turbolinks 5 without a problem.

The one event binding that was needed was page:before-node-removed which I think could be above page:after-node-removed at

turbograft/lib/assets/javascripts/turbograft/turbolinks.coffee

Lines 51 to 57 in 8fbcd22

	replaceNode = (newNode, oldNode) ->
	replacedNode = oldNode.parentNode.replaceChild(newNode, oldNode)
	triggerEvent('page:after-node-removed', replacedNode)
	removeNode = (node) ->
	removedNode = node.parentNode.removeChild(node)
	triggerEvent('page:after-node-removed', removedNode)

You can close this if you don't think it's necessary to add any events, at first I think I had expectations of turbolinks 4 events (currently turbolinks-classic)