Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-end term timer #13

Open
Hacime opened this issue Aug 15, 2021 · 8 comments
Open

Auto-end term timer #13

Hacime opened this issue Aug 15, 2021 · 8 comments
Labels
backend Pull requests that update the backend Java code frontend Pull requests that update frontend Javascript/Typescript code new feature New feature or request

Comments

@Hacime
Copy link

Hacime commented Aug 15, 2021

Hi,
could the "End Term" button be removed?
It doesn't really have a function, so we think the game would be more smooth if it just would continue without
waiting to press "End Term".
We often have to remind players to press "End Term" and we would sometimes feel a bit annoyed to keep reminding each other to press "End Term" :)

@ShrimpCryptid ShrimpCryptid added the new feature New feature or request label Aug 16, 2021
@ShrimpCryptid
Copy link
Owner

Hmm, the original intention was to have the button there so that there would be time for discussion before the next president's term started.

Do you still think it would be more useful to immediately jump into the next president's term? They would immediately be shown the chancellor selection view and wouldn't be able to see the order of players/presidents after them.

@Hacime
Copy link
Author

Hacime commented Aug 16, 2021

So that's the intention behind...
We have been playing twice a week on this website for several weeks and I can say that most of us feel annoyed by the button :)
I'm quite sure it would make the gameplay smoother and more enjoyable without it.
Maybe there can be a short delay like 3 seconds before the game continues automatically.

I would have 2 suggestions regarding the visibility of the player list:
a) Would it be possible to move the selection screen a bit further down so the original player list would be still visible? or would that spoil the experience on mobile devices as it would maybe need to much of scrolling? on my laptop screen there is enough space to do that.

b) Or, could the selection screen show the players list in the same order and size as the original player list?

Both options would work I guess.

As usual, I would like to mention, this project is well done.

@ShrimpCryptid
Copy link
Owner

I think having the game progress automatically after a delay is a good suggestion! I may include an option in the Lobby where you can set how long that delay is.

I have an idea for having the End Term button progress over the duration (to indicate that there's a delay occurring) before automatically ending the term, though I'll need to do some testing to get it looking nice.

@Hacime
Copy link
Author

Hacime commented Aug 17, 2021

Cool, adjusting the delay would fit everybody's needs I guess. just want to mention if the button is removed we would already be happy I think.
Anything else like the idea with the delay seems like a nice extra. if u prefer, u could only remove the button
and adjust the player selection screen and I could give u a feedback if we felt like a delay setting is necessary. maybe when trying that way it turns out to be fine already.
but both sounds good. if u like the delay setting more or if that's easier, either way would be good. was just another thought.

@Hacime
Copy link
Author

Hacime commented Aug 22, 2021

Update: I paid attention to this the last time we played and it felt okay to me if the button would be removed even without an extra delay. usually I click immediately end term. FYI

@nvgokhale
Copy link

Seconding this - would really like to see this feature implemented soon!

@depopry
Copy link

depopry commented Aug 24, 2023

👍 to this feature, or something similar. I find most games the need to chase someone to click End Term.

Possibly a configurable delay, or set up the game with an "auto-end term" options?

@ShrimpCryptid ShrimpCryptid changed the title Remove of End Term Button Auto-end term timer Apr 17, 2024
@ShrimpCryptid ShrimpCryptid moved this from New to Backlog in Secret Hitler Online Apr 17, 2024
@ShrimpCryptid ShrimpCryptid added backend Pull requests that update the backend Java code frontend Pull requests that update frontend Javascript/Typescript code labels Apr 17, 2024
@ShrimpCryptid
Copy link
Owner

Adding a note here, this also would require a server API update to save lobby settings + configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Pull requests that update the backend Java code frontend Pull requests that update frontend Javascript/Typescript code new feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

4 participants